----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/126/#review339 -----------------------------------------------------------
Ship it! Ship It! - Will Andrews On Nov. 16, 2014, 12:01 a.m., Justin Gibbs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/126/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2014, 12:01 a.m.) > > > Review request for OpenZFS Developer Mailing List and Matthew Ahrens. > > > Bugs: 5310 > https://www.illumos.org/projects/illumos-gate//issues/5310 > > > Repository: illumos-gate > > > Description > ------- > > Remove always true tests for ds->ds_phys' presence. > Clean up assertions in dsl_dataset_disown. > Remove unreachable code in dsl_dataset_disown(). > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/dsl_prop.c > 7e62635176dfb1f5f640369ba7c72273ecaa85cc > usr/src/uts/common/fs/zfs/dsl_dataset.c > e7ed7509020851f991999f21138b1b156d8d2948 > > Diff: https://reviews.csiden.org/r/126/diff/ > > > Testing > ------- > > zfs test suite > ztest > > for help with preparing your RTI email, see below. Re-run the git commands > with your final commit message (with reviewers listed) and author (Justin) > > (internal link: http://jenkins/job/zfs-precommit/1135/console) > > ``` > ##### Begin Illumos advocates mail ##### > <<< INSERT YOUR PUBLICLY VISIBLE REVIEWBOARD URL HERE >>> > > Chris will do the push once someone approves it. > > $ git whatchanged HEAD^.. > commit 044797abf583dcb962955b46556e692dd9ad59aa > Author: Justin T. Gibbs <just...@spectralogic.com> > Date: Tue Nov 11 10:12:52 2014 -0800 > > Remove always true tests for non-NULL ds->ds_phys > > :100644 100644 e7ed750... 5ac0050... M > usr/src/uts/common/fs/zfs/dsl_dataset.c > :100644 100644 7e62635... 5907ea2... M > usr/src/uts/common/fs/zfs/dsl_prop.c > > $ git pbchk -b HEAD^ > Comments: > These comments are not valid bugs: > Remove always true tests for non-NULL ds->ds_phys > > > ==== Nightly distributed build started: Sat Nov 15 08:26:56 PST 2014 ==== > ==== Nightly distributed build completed: Sat Nov 15 11:47:49 PST 2014 ==== > > ==== Total build time ==== > > real 3:20:53 > > ==== Build environment ==== > > /usr/bin/uname > SunOS totality 5.11 os-build-build-2161 i86pc i386 i86pc > > /usr/bin/dmake > dmake: Sun Distributed Make 7.9 SunOS_i386 2009/06/03 > number of concurrent jobs = 6 > > 32-bit compiler > /opt/onbld/bin/i386/cw -_gcc > cw version 1.29 (SHADOW MODE DISABLED) > primary: /opt/gcc/4.4.4/bin/gcc > gcc (Illumos gcc-4.4.4-il-3) 4.4.4 > > 64-bit compiler > /opt/onbld/bin/i386/cw -_gcc > cw version 1.29 (SHADOW MODE DISABLED) > primary: /opt/gcc/4.4.4/bin/gcc > gcc (Illumos gcc-4.4.4-il-3) 4.4.4 > > /usr/java/bin/javac > java full version "1.6.0_26-b03" > > /usr/ccs/bin/as > as: Sun Compiler Common 12 SunOS_i386 snv_121 08/03/2009 > > /usr/ccs/bin/ld > ld: Software Generation Utilities - Solaris Link Editors: 5.11-1.1749 > (illumos) > > Build project: group.staff > Build taskid: 328 > > ==== Nightly argument issues ==== > > > ==== Build version ==== > > os-build-build-2580 > > ==== Make clobber ERRORS ==== > > > ==== Make tools clobber ERRORS ==== > > > ==== Tools build errors ==== > > > ==== Build errors (non-DEBUG) ==== > > > ==== Build warnings (non-DEBUG) ==== > > > ==== Elapsed build time (non-DEBUG) ==== > > real 44:46.4 > user 1:39:58.0 > sys 30:44.1 > > ==== Build noise differences (non-DEBUG) ==== > > > ==== package build errors (non-DEBUG) ==== > > > ==== Build errors (DEBUG) ==== > > > ==== Build warnings (DEBUG) ==== > > > ==== Elapsed build time (DEBUG) ==== > > real 1:05:06.8 > user 1:28:14.3 > sys 22:59.6 > > ==== Build noise differences (DEBUG) ==== > > > ==== package build errors (DEBUG) ==== > > > ==== Validating manifests against proto area ==== > > > ==== Check ELF runtime attributes ==== > > > ==== Diff ELF runtime attributes (since last build) ==== > > > ==== 'dmake lint' of src ERRORS ==== > > > ==== Elapsed time of 'dmake lint' of src ==== > > real 1:05:22.8 > user 1:14:41.8 > sys 17:04.3 > > ==== lint warnings src ==== > > > ==== lint noise differences src ==== > > > ==== cstyle/hdrchk errors ==== > > > ==== Find core files ==== > > > ==== Check lists of files ==== > > > ==== Impact on file permissions ==== > > > ==== Running POST_NIGHTLY command: > /data/jenkins/zfs-precommit/build-1135-2e03/jenkins_helper.sh ==== > > ##### End Illumos advocates mail ##### > ``` > > > Thanks, > > Justin Gibbs > >
_______________________________________________ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer
