----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/167/#review543 -----------------------------------------------------------
Ship it! Ship It! - George Wilson On Feb. 27, 2015, 7:45 p.m., Xin LI wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/167/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 7:45 p.m.) > > > Review request for OpenZFS Developer Mailing List and Christopher Siden. > > > Bugs: 5669 > https://www.illumos.org/projects/illumos-gate//issues/5669 > > > Repository: illumos-gate > > > Description > ------- > > Currently, 'altroot' is only set when zpool create sees '-R'. It should be > also set if -o altroot= is used. > > Without this change, e.g zpool create -o altroot=/install_target usr would > fail if /usr is not empty. > > > Diffs > ----- > > usr/src/cmd/zpool/zpool_main.c 8b992efcb4e4c98581e109dc1f983b6b9d2ef104 > > Diff: https://reviews.csiden.org/r/167/diff/ > > > Testing > ------- > > Tested on FreeBSD. > > The change can be tested with "zpool create -o altroot=/somedir [an existing > non-empty directory in /] [some device]" on Illumos. > > > Thanks, > > Xin LI > >
_______________________________________________ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer