> On March 9, 2015, 3:36 p.m., Josef 'Jeff' Sipek wrote: > > usr/src/uts/common/fs/zfs/dmu_traverse.c, line 41 > > <https://reviews.csiden.org/r/172/diff/1/?file=14363#file14363line41> > > > > why signed? > > > > Does 50MB have some special meaning? Or is just just a "random" value > > >12MB?
I left it as signed since that's what pd_bytes_fetched is. The 50MB value is actually a conservative number and we saw good performance gains with our workload (mostly 8KB blocks). Remember that 12MB used before is only true if your stream is mostly 128KB block. - George ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/172/#review566 ----------------------------------------------------------- On March 9, 2015, 2:34 p.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/172/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 2:34 p.m.) > > > Review request for OpenZFS Developer Mailing List and Christopher Siden. > > > Bugs: 5694 > https://www.illumos.org/projects/illumos-gate//issues/5694 > > > Repository: illumos-gate > > > Description > ------- > > 5694 traverse_prefetcher does not prefetch enough > Reviewed by: Matthew Ahrens <mahr...@delphix.com> > Reviewed by: Alex Reece <a...@delphix.com> > Reviewed by: Christopher Siden <christopher.si...@delphix.com> > > Original author: George Wilson > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/dmu_traverse.c > 14eef2e7516c9b5e717ef318321ee137dcd19c9f > > Diff: https://reviews.csiden.org/r/172/diff/ > > > Testing > ------- > > ztest; zfs test suite > > http://jenkins/job/zfs-precommit/1821/ > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer
