> On April 13, 2015, 4:47 p.m., Gordon Ross wrote: > > usr/src/cmd/mdb/common/mdb/mdb_proc.c, line 1570 > > <https://reviews.csiden.org/r/202/diff/1/?file=14994#file14994line1570> > > > > Are we in any danger of blowing the kmdb stack with all these big > > arrays defined as locals? > > If this code is never called reentrant, they could be just static.
or mdb_alloc them, or ... - Gordon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/202/#review664 ----------------------------------------------------------- On April 10, 2015, 4:18 p.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/202/ > ----------------------------------------------------------- > > (Updated April 10, 2015, 4:18 p.m.) > > > Review request for OpenZFS Developer Mailing List. > > > Bugs: 5816 > https://www.illumos.org/projects/illumos-gate//issues/5816 > > > Repository: illumos-gate > > > Description > ------- > > 5816 mdb '::status' truncates assertion messages > Reviewed by: Sebastien Roy <sebastien....@delphix.com\> > Reviewed by: Matthew Ahrens <mahr...@delphix.com\> > > Original author: Prakash Surya > > > Diffs > ----- > > usr/src/cmd/mdb/common/mdb/mdb_proc.c > 2a3e49131391fb59f80d772ce55ee88bda4325c5 > > Diff: https://reviews.csiden.org/r/202/diff/ > > > Testing > ------- > > run ::status on a core file (compare with message from > https://reviews.csiden.org/r/201/) > > > ::status > debugging core file of ztest (32-bit) from oi-151 > file: /usr/bin/i86/ztest > initial argv: /usr/bin/i86/ztest > threading model: native threads > status: process terminated by SIGABRT (Abort), pid=102185 uid=101 code=-1 > panic message: > assertion failed for thread 0xf09c5a40, thread-id 588: > refcount_count(&tx->tx_space_written) + delta <= tx->tx_space_towrite > (0x300000 <= 0x2a0000), file ../../../uts/common/fs/zfs/dmu_tx.c, line 1369 > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer