----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/251/#review800 -----------------------------------------------------------
Ship it! LGTM usr/src/uts/common/fs/zfs/dbuf.c (line 1137) <https://reviews.csiden.org/r/251/#comment612> The async COW code (which I'm again working on upstreaming) for this path includes this comment and assert. This was probably added when Will and I were working to understand things. Perhaps useful to future readers? ``` /* Already released on initial dirty, so just thaw. */ ASSERT(arc_released(db->db_buf)); ``` usr/src/uts/common/fs/zfs/dbuf.c (line 1210) <https://reviews.csiden.org/r/251/#comment613> It would be nice to just replace support for redirtying in the same TXG in this code path with an ASSERT and have all callers of dbuf_dirty() do the check. Perhaps combine dbuf_redirty() and the "Quick check for dirtyness" code in dmu_buf_will_dirty() into dbuf_was_redirtied() then the callers can just do: ''' if (dbuf_was_redirtied(db, tx)) return; ''' - Justin Gibbs On Oct. 6, 2015, 4:07 p.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/251/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 4:07 p.m.) > > > Review request for OpenZFS Developer Mailing List and Christopher Siden. > > > Bugs: 6288 > https://www.illumos.org/issues/6288 > > > Repository: illumos-gate > > > Description > ------- > > 6288 dmu_buf_will_dirty could be faster > Reviewed by: George Wilson <george.wil...@delphix.com> > Reviewed by: Paul Dagnelie <p...@delphix.com> > > Original author: Matthew Ahrens > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/dbuf.c e75bac094ecba982dc4bbcb8a5d2faad2a5c0a9f > > Diff: https://reviews.csiden.org/r/251/diff/ > > > Testing > ------- > > http://jenkins.delphix.com/job/os-build/4661/console > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer
