----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/250/#review818 -----------------------------------------------------------
usr/src/uts/common/fs/zfs/dsl_scan.c (lines 1421 - 1427) <https://reviews.csiden.org/r/250/#comment617> Wouldn't it be better to merge this logic into dsl_scan_active() so that the policy is contained in one place? Something like: ```c if (!dsl_scan_active(scn, INCLUDE_STALLED_SCANS)) return; ``` usr/src/uts/common/fs/zfs/dsl_scan.c (lines 1422 - 1432) <https://reviews.csiden.org/r/250/#comment616> Wouldn't it be better to merge this logic into dsl_scan_active() so pieces of the policy aren't duplicated? Something like: '''c if (!dsl_scan_active(scn, INCLUDE_STALLED_SCANS)) return; ''' - Justin Gibbs On Oct. 7, 2015, 3:02 a.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/250/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 3:02 a.m.) > > > Review request for OpenZFS Developer Mailing List and Christopher Siden. > > > Bugs: 6292 > https://www.illumos.org/issues/6292 > > > Repository: illumos-gate > > > Description > ------- > > 6292 exporting a pool while an async destroy is running can leave entries in > the deferred tree > Reviewed by: Paul Dagnelie <p...@delphix.com> > Reviewed by: Matthew Ahrens <mahr...@delphix.com> > > Original author: George Wilson > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/dsl_scan.c > 6ba5cb6a1c831f681fba16dbc8d25fd8b59b13c9 > > Diff: https://reviews.csiden.org/r/250/diff/ > > > Testing > ------- > > http://jenkins.delphix.com/job/zfs-precommit/3149/ > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer
