----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/259/#review833 -----------------------------------------------------------
usr/src/uts/common/fs/zfs/dmu.c (lines 444 - 447) <https://reviews.csiden.org/r/259/#comment628> I don't see that DNODE_IS_CACHEABLE has ever existed in illumos. usr/src/uts/common/fs/zfs/dmu_zfetch.c (line 52) <https://reviews.csiden.org/r/259/#comment623> can you clarify if this is "bytes of the file" vs "bytes of indirects"? i.e. will we use an additional 64MB memory per stream, vs approximately 64MB / block size * sizeof(blkptr_t) usr/src/uts/common/fs/zfs/dmu_zfetch.c (lines 266 - 268) <https://reviews.csiden.org/r/259/#comment625> nice cleanup usr/src/uts/common/fs/zfs/dmu_zfetch.c (line 269) <https://reviews.csiden.org/r/259/#comment624> cstyle says that if one side of the if/else has braces, both should. usr/src/uts/common/fs/zfs/dmu_zfetch.c (lines 285 - 286) <https://reviews.csiden.org/r/259/#comment627> I think I understand why you are rounding up the start -- if the start is misaligned (not at the beginning of the indirect block) we would have alread prefetched this indirect last time. Why do you round up the end? It seems like you would want to end on the indirect that contains the ending level-0 blkid (zs_ibf_blkid). usr/src/uts/common/fs/zfs/sys/dmu_zfetch.h (line 46) <https://reviews.csiden.org/r/259/#comment626> it would be helpful to specify that this is the blkid of the level-0 block whose level-1 indirect we will prefetch (as opposed to the blkid of the next level-1 indirect to prefetch) - Matthew Ahrens On Oct. 12, 2015, 4:33 p.m., Alexander Motin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/259/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 4:33 p.m.) > > > Review request for OpenZFS Developer Mailing List and Christopher Siden. > > > Bugs: 6322 > https://www.illumos.org/issues/6322 > > > Repository: illumos-gate > > > Description > ------- > > 6322 ZFS indirection tables prefetch > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/dmu_zfetch.c > f2cdf863d83c9ecb627a3b566c4c09553e4b9666 > usr/src/uts/common/fs/zfs/dmu.c 5b24268af1a813c153c75e8531cb3a6e23baa406 > usr/src/uts/common/fs/zfs/dbuf.c 8b0c71db5c86fab2219699f4e3b2eccf00de545c > usr/src/uts/common/fs/zfs/sys/dnode.h > 69cc54dc272b143b085f897b956bb9cdd8c09bf3 > usr/src/uts/common/fs/zfs/sys/dmu_zfetch.h > 6f61198ebc4528f58761f56a11610cb2fbefadd3 > > Diff: https://reviews.csiden.org/r/259/diff/ > > > Testing > ------- > > Tested on FreeBSD head system. > > > Thanks, > > Alexander Motin > >
_______________________________________________ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer
