Code looks good to me.
I don't see those tests failing on the other os-zfs-test runs. Here are some
log snippets of this test run. It does look like an error with `share`. It
looks like it's trying to share something on rpool. Could `share` be looking
for the zfs filesystem that backs it and not able to find it due to your
changes to not iterate over rpool?
```
Test: /opt/zfs-tests/tests/functional/delegate/zfs_allow_010_pos (run as root)
[01:37] [FAIL]
....
21:47:46.29 SUCCESS: restore_root_datasets
21:47:46.41 SUCCESS: /usr/sbin/zfs allow staff1 destroy
testpool.101006/testfs.101006
21:47:47.25 SUCCESS: /usr/sbin/zfs allow staff1 mount
testpool.101006/testfs.101006
21:47:47.80 SUCCESS: verify_perm testpool.101006/testfs.101006 destroy staff1
21:47:48.28 SUCCESS: /usr/sbin/zfs create testpool.101006/testfs.101006
21:47:48.52 SUCCESS: /usr/sbin/zfs destroy -Rf testpool.101006/testvol.delegate
21:47:48.77 SUCCESS: /usr/sbin/zfs create -V 150m
testpool.101006/testvol.delegate
21:47:48.77 SUCCESS: restore_root_datasets
21:47:48.89 SUCCESS: /usr/sbin/zfs allow staff1 sharenfs
testpool.101006/testfs.101006
21:47:48.94 NOTE: staff1 /usr/sbin/zfs set sharenfs=on
testpool.101006/testfs.101006
21:47:50.06 SUCCESS: /usr/sbin/zfs set sharenfs=off
testpool.101006/testfs.101006
21:47:50.07 SUCCESS: /usr/bin/mkdir -p /var/tmp/a.555758
21:47:50.11 ERROR: /usr/sbin/share /var/tmp/a.555758 exited 32
21:47:50.12 Could not share: /var/tmp/a.555758: system error
21:47:50.12 NOTE: Performing local cleanup via log_onexit
(restore_root_datasets)
21:47:50.60 SUCCESS: /usr/sbin/zfs destroy -Rf testpool.101006/testfs.101006
21:47:51.07 SUCCESS: /usr/sbin/zfs create testpool.101006/testfs.101006
21:47:51.22 SUCCESS: /usr/sbin/zfs destroy -Rf testpool.101006/testvol.delegate
21:47:51.37 SUCCESS: /usr/sbin/zfs create -V 150m
testpool.101006/testvol.delegate
21:47:51.38 Last login: Tue Jan 19 21:46:12 2016 from openzfs-r151014
....
Test: /opt/zfs-tests/tests/functional/delegate/zfs_allow_012_neg (run as root)
[01:38] [FAIL]
....
21:49:28.81 SUCCESS: restore_root_datasets
21:49:29.10 SUCCESS: /usr/sbin/zfs allow staff1 destroy
testpool.101006/testfs.101006
21:49:29.51 SUCCESS: /usr/sbin/zfs allow staff1 mount
testpool.101006/testfs.101006
21:49:29.55 SUCCESS: verify_noperm testpool.101006/testfs.101006 destroy staff1
21:49:29.84 SUCCESS: /usr/sbin/zfs destroy -Rf testpool.101006/testfs.101006
21:49:30.11 SUCCESS: /usr/sbin/zfs create testpool.101006/testfs.101006
21:49:30.42 SUCCESS: /usr/sbin/zfs destroy -Rf testpool.101006/testvol.delegate
21:49:30.78 SUCCESS: /usr/sbin/zfs create -V 150m
testpool.101006/testvol.delegate
21:49:30.78 SUCCESS: restore_root_datasets
21:49:31.15 SUCCESS: /usr/sbin/zfs allow staff1 sharenfs
testpool.101006/testfs.101006
21:49:31.20 NOTE: staff1 /usr/sbin/zfs set sharenfs=on
testpool.101006/testfs.101006
21:49:31.24 SUCCESS: verify_noperm testpool.101006/testfs.101006 sharenfs staff1
21:49:31.47 SUCCESS: /usr/sbin/zfs destroy -Rf testpool.101006/testfs.101006
21:49:31.70 SUCCESS: /usr/sbin/zfs create testpool.101006/testfs.101006
21:49:31.95 SUCCESS: /usr/sbin/zfs destroy -Rf testpool.101006/testvol.delegate
21:49:32.63 SUCCESS: /usr/sbin/zfs create -V 150m
testpool.101006/testvol.delegate
21:49:32.64 SUCCESS: restore_root_datasets
21:49:32.89 SUCCESS: /usr/sbin/zfs allow staff1 share
testpool.101006/testfs.101006
21:49:32.99 SUCCESS: /usr/bin/mkdir -p /var/tmp/a.557950
21:49:33.03 ERROR: /usr/sbin/share /var/tmp/a.557950 exited 32
21:49:33.03 Could not share: /var/tmp/a.557950: system error
21:49:33.04 NOTE: Performing local cleanup via log_onexit (cleanup)
21:49:33.26 SUCCESS: /usr/sbin/zpool set delegation=on testpool.101006
21:49:33.41 SUCCESS: /usr/sbin/zfs destroy -Rf testpool.101006/testfs.101006
21:49:33.57 SUCCESS: /usr/sbin/zfs create testpool.101006/testfs.101006
21:49:34.22 SUCCESS: /usr/sbin/zfs destroy -Rf testpool.101006/testvol.delegate
21:49:34.48 SUCCESS: /usr/sbin/zfs create -V 150m
testpool.101006/testvol.delegate
21:49:34.48 SUCCESS: restore_root_datasets
21:49:34.49 Last login: Tue Jan 19 21:47:51 2016 from openzfs-r151014
```
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/58#issuecomment-173086357
_______________________________________________
developer mailing list
developer@open-zfs.org
http://lists.open-zfs.org/mailman/listinfo/developer
