@yuripankov Reading through the comments again, I think the outstanding issues 
are:

* should be able to specify c0t0d0 and it should know you mean 
/dev/dsk/c0t0d0s0 (like "zpool add" does) - looks like we will add the 
`/dev/dsk` but not the `s0`
* don't do anything if there are no valid labels (zpool_in_use() returns 
nonzero)
* potentially making it only zero labels that exist (if some but not all labels 
exist) - not sure this is a requirement but would be nice.
* long string style issue
* printf arg issue

@wca, are you able to continue working on this?  If not then maybe @yuripankov 
you could pick it up from here?

---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/32#issuecomment-174371260
_______________________________________________
developer mailing list
developer@open-zfs.org
http://lists.open-zfs.org/mailman/listinfo/developer

Reply via email to