Jan Pokorný <[email protected]> wrote:
On 07/06/18 11:10 +0000, Nils Carlson wrote:
The fundamental unit of review in Gitlab is the merge-request, requesting
that a branch be merged into another. This works very well in practice. You
can configure a regex for branch names and only allow users to push to
branches with a prefix like "contributions/", making all other branches
"protected", i.e. prevent direct pushes.
The code-review is good, but could be better. Every time you update the
branch (either amending a commit or pushing a new commit) this creates a new
"version" of the merge-request that you can diff against previous versions.
I must admit, this would be a killer feature for me (see the above
rant) and best trade-off if the willingness to try/adopt Gerrit
is unlikely.
Ooh that is indeed a killer feature! I hadn't spotted that with
GitLab yet. That puts it way ahead of GitHub in the code review
space.
https://github.com/isaacs/github/issues/999
_______________________________________________
Developers mailing list
[email protected]
https://lists.clusterlabs.org/mailman/listinfo/developers
