Rob van Maris <[EMAIL PROTECTED]> skribis: > In order to make these tags work according to the TLD, the method > setTransaction() of CommitTag has to be public. > WebLogic complaints about this already when reading the TLD. Other > application servers may not do so, but they will start throwing exceptions > immediately when these tags are used with the "transaction" attribute. > > Apparently, the tags have never been tested. Very bad.
This is a huge exaggeration. These tags will work perfectly right without the 'transaction' attribute, which only exists for symmetry.. I'm glad you fixed it though. I do agree that the tags (and in fact most parts of mmbase) are not tested systematticly enough. Therefore the 'test' directory in the source repository exists (only 'bridge' tests), and I put a bunch of jsp's in speeltuin/mihxil/test/jsp/taglib, by wich I try to test the tags as profoundly as I can, but this is not yet complete (Hey, I can't do everything _alone_!), and obviously I forgot about the 'transaction' attribute. You can see there however that both the 'cancel' and the 'commit' tags _are_ tested. Michiel -- % Michiel Meeuwissen % [EMAIL PROTECTED] % http://www.purl.org/NET/mihxil/ % Vidu ankaux: http://www.uea.org/katalogo
