[EMAIL PROTECTED] wrote: > > The dtd directory of the 'config' module will appear as > > mmbase.jar!/org/mmbase/resources/dtd > > [_] -1 (NAY), because : > I'm in favour or moving the dtd's inside the classpath, but as to their > location more discussion is required. > I suggest we comply to the de facto standard in the j2ee world, which is > inside a subdirectory directory "resources" in the associated package. > E.g. servlet.jar contains web-app_2_3.dtd in javax/servlet/resources > and web-jsptaglibrary_1_2.dtd in javax/servlet/jsp/resources. > > Accordingly, in MMBase transactions.dtd should go in > org/mmbase/applications/xmlimporter/resources, security.dtd should go in > org/mmbase/security/resources, etcetera. > This makes sense since the dtd's are tightly coupled to code, so they can > be put in the package hierarchy in a meaningful manner. > I realize there was opportunity to discuss this preceding the call for > vote, but I just returned from vacation today and I still would like to > suggest this as an alternative.
Perhaps you are right, but most XML's are read by org.mmbase.util.XMLBasicReader, which would mean that the dtd's simply appear in org.mmbase.util.resources or perhaps better it should be instantiated with 'this' (which can be passed to the entityresolver which then can use the classloader of this calling-class). The way I proposed is much simpler to implement, and I think even with your -1 will propably make it, but I would encourage moving the dtd's to the source directory in the way you proposed, and adaping the XMLBasicReader/XMLEntityResolver accordingly. It will have several implications I think (e.g. can the PUBLIC and SYSTEM id stay the same?), So i'm +1 for this modification later, but also for the quick step of moving dtd's to the jar ASAP. Perhaps the distro project/ CVS maintainer can then decide on where the dtd's must be stored in CVS/the source tree? Michiel -- Michiel Meeuwissen Mediapark, C 107 tel. +31 (0)35 6772979
