On Monday 20 January 2003 12:28 pm, Rob van Maris wrote: > <Kees Jongenburger:> > > > The current code as i wrote it is located here > > http://carlit.mine.nu/~keesj/MMObjectBuilder.java > > getNonByteArrayFields.. > > Looks essentially OK, but I propose some modifications: > 1) Test for eiter DBSTATE_PERSISTENT or DBSTATE_SYSTEM, instead of just the > first. This will get you all the fields you need, including otype. > 2) Make the method protected instead of public. No need to add to the > plethora of public methods in MMObjectBuilder. This method should not be > available to code outside the builder classes. > > Besides, I think adding a public method would require a vote.
a "new" version is avaiable http://carlit.mine.nu/~keesj/MMObjectBuilder.java changes : -method is now private -mmb.getBuilder(builderName).getFields(FieldDefs.ORDER_CREATE).iterator(); because sometime the builder excuting the query != the builder queried??? I have also commited a change to MagicFile that prevents the whole byte[] to be sent (only the first xxx bytes) it' still possible that nodes containing handles wil get in the node cache (i can't prevent it for the moment. and mabye it is not desired).
