I agree, we should change this.
The javadoc sais:
/**
* checks if the attribute buildername is an instance of this builder.
* @param buildername a builder name
* @return <true> if the buildername is an instance of this builder, <false> otherwise.
*
* @since MMBase-1.6
*/
public boolean isInstanceOfBuilder(String builderName) {
So, I'd say this is completely counterintuitive. I think every
programmer would expect posrel.isInstanceOfBuilder(insrel) to be true
and not insrel.isInstanceOfBuilder(posrel).
But do we really need to make things deprecated?
I don't think that the method is used by 3th parties (especially because it was private), so i would suggest to just adapt the code that is involved.
I added the word Builder to isInstanceOfBuilder to avoid confusion with the isinstanceof operator.
But isExtensionOf is fine with me.
greetings Rob
