Pierre van Rooden wrote:
> >>CONFIG :
> >
> >I don't know. I think this involves fixing the admin-pages too?
>
> Yes, all refernces to the 'config' module will be removed from the admin
> pages if Config is moved out of the core.
+1 for removing.
>
> >>MAIL :
> >
> >I want to make a distinction here:
> >
> >>- module/AbstractSendMail.java
> >>- module/JMSendMail.java
> >>- module/SendMail.java
> >>- module/SendMailInterface.java
> >>
> >>[X] Keep in Core
> >
> >>- module/builders/EmailSendProbe.java
> >>- module/builders/Email.java
> >>- module/builders/EmailQueueProbe.java
> >>- util/Mail.java
> >>
> >>[X] Drop the code
>
> I don't mind if you want to split this, but do it right then: 'Mail' is
> used in 'SendMailInterface'
I suggest to drop the particular method from SendMailInterface then, if
possible, which I think it is, because the implementation in in
AbstractSendMail is quit straighforward:
/**
* Send mail
*/
public boolean sendMail(Mail mail) {
return sendMail(mail.from, mail.to, mail.text, mail.headers);
}
So, I don't really see to point of wrapping it into a Mail object first.
Michiel
--
Michiel Meeuwissen mihxil'
Mediacentrum 140 H'sum [] ()
+31 (0)35 6772979 nl_NL eo_XX en_US
