[PATCH 1/3] firewall: Collect all networks that should not be NATed in an array

[Michael Tremer]

No functional changes.

Signed-off-by: Michael Tremer <michael.tre...@ipfire.org>
---
 src/initscripts/system/firewall | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/initscripts/system/firewall b/src/initscripts/system/firewall
index 139d94aa0..6d9c00282 100644
--- a/src/initscripts/system/firewall
+++ b/src/initscripts/system/firewall
@@ -481,22 +481,22 @@ iptables_red_up() {
                        iptables -t nat -A REDNAT -i "${GREEN_DEV}" -o 
"${IFACE}" -j RETURN
                fi
 
-               local NO_MASQ_NETWORKS
+               local NO_MASQ_NETWORKS=()
 
                if [ "${MASQUERADE_GREEN}" = "off" ]; then
-                       NO_MASQ_NETWORKS="${NO_MASQ_NETWORKS} 
${GREEN_NETADDRESS}/${GREEN_NETMASK}"
+                       NO_MASQ_NETWORKS+=( 
"${GREEN_NETADDRESS}/${GREEN_NETMASK}" )
                fi
 
                if [ "${MASQUERADE_BLUE}" = "off" ]; then
-                       NO_MASQ_NETWORKS="${NO_MASQ_NETWORKS} 
${BLUE_NETADDRESS}/${BLUE_NETMASK}"
+                       NO_MASQ_NETWORKS+=( 
"${BLUE_NETADDRESS}/${BLUE_NETMASK}" )
                fi
 
                if [ "${MASQUERADE_ORANGE}" = "off" ]; then
-                       NO_MASQ_NETWORKS="${NO_MASQ_NETWORKS} 
${ORANGE_NETADDRESS}/${ORANGE_NETMASK}"
+                       NO_MASQ_NETWORKS+=( 
"${ORANGE_NETADDRESS}/${ORANGE_NETMASK}" )
                fi
 
                local network
-               for network in ${NO_MASQ_NETWORKS}; do
+               for network in ${NO_MASQ_NETWORKS[@]}; do
                        iptables -t nat -A REDNAT -s "${network}" -o "${IFACE}" 
-j RETURN
                done
 
-- 
2.39.5