I don't think I can comment under the individual lines, but I did comment on the commit as a whole
On Thu, Dec 6, 2018 at 11:32 PM Edward Welbourne <[email protected]> wrote: > NIkolai Marchenko (6 December 2018 21:24) > >> If you witness others being attacked, think first about how you can > offer them personal support. > > >> As a first step when problems arise, consider reminding those involved > of our Code of Conduct. > > > these... kinda contradict each other. Just a minor nitpick. I do not > disagree, just that the priorities conflict > > If you're able to comment on the code review [0], > doing so there will better fit in with the process. > > * [0] https://codereview.qt-project.org/243623 > > Eddy. >
_______________________________________________ Development mailing list [email protected] https://lists.qt-project.org/listinfo/development
