On 1/6/12 8:08 PM, "ext Thiago Macieira" <thiago.macie...@intel.com> wrote:
>On Friday, 6 de January de 2012 15.45.13, lars.kn...@nokia.com wrote: >> >- Go over the modules and factor out platform stuff like: >> > >> >#if defined(Q_WS_WIN) >> > >> > SystemParametersInfo(SPI_GETDROPSHADOW, 0, &shadow, 0); >> > shadowWidth = shadow ? 0 : 6; >> > >> > } >> > >> >#elsif defined(Q_WS_MAC) >> > >> > shadowWidth = .... >> > >> >#endif >> > >> >The API needs to be as flexible as possible (QVariant themeHint(enum >> >what)). Still, if the feature freeze happens before finishing the >> >reorganization or important stuff that needs to go to those plugins is >> >discovered later on, there is a chance for source compatibility >>breakage. >> >> Same as above. I agree with you in an ideal world, and the more we can >>do >> here for 5.0 already the better. But if we don't get it all done and do >> have some platform dependencies in there, it's most likely not the end >>of >> the world for 5.0 :) > >Any and all Q_WS_* outside the platform plugins must be gone by the time >of >5.0 release. They are dead code. True, unless we decide to set the defines for QtWidgets. But you're right, it would be a lot better to get them out and move the code into a platform plugin. Lars _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development