On sexta-feira, 13 de abril de 2012 11.30.42, Girish Ramakrishnan wrote: > Yes, agreed (and thanks for those pragmas that I was not aware of).
Remember to wrap them in #if 0, so only syncqt will see them.
> I think the idea with _qpa_ in the file name is to imply that it has
> plugin api. As opposed to let's say qpen_p.h. This means that when I
> see a change to a _qpa.h file, I know that plugins will get affected
> by this api change. However, this fact can already be deduced from the
> qplatform prefix. The only exceptions, I see are:
> 1. qwindowsysteminterface, which can be renamed at some point to be
> qplatformwindowsystemitnterface
> 2. qgenericplugin, which can also be renamed
qgenericplugin needs to be renamed since it's an oxymoron. The concept of
"generic plugin" makes no sense.
Those are QPA extra plugins that can be used independent of the main QPA
platform plugin. But they really need to go away completely. It makes no sense
for a user to decide to use an extra evdev plugin when running xcb.
In fact, I'd also remove the -platform option too. Leave the environment
variable for overrides and auto-detection as the main way.
> So, let's rename _qpa.h to qplatform*_p.h. Ok?
Yes, please.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
