On Monday 15 October 2012 20:38:04 Sze Howe Koh wrote: > Discussion at > https://codereview.qt-project.org/#patch,sidebyside,36806,5,src/corelib/thre > ad/qthread.cpp > > Thiago: "Shouldn't this say that it's undefined if the [terminated()] > signal is emitted at all [upon forced termination]?" > Olivier: "Then should we just remove that signal? (Because it is undefined > if the program will not deadlock if one call terminate. If terminate() is > called when the thread holds the QThread's internal mutex for example, or > any other Qt mutex (there is so many), Or even user mutexes.)" > > Is there any value in keeping a signal that is: > - Only emitted after the program destabilises, and > - Not even guaranteed to be emitted?
I even go as far as removing it. Source compatibility is not really broken since you will just get a runtime warning saying the signal don't exist. -- Olivier PS: sorry for the few last duplicate emails. Woboq - Qt services and support - http://woboq.com _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
