On Jan 7, 2013, at 7:01 AM, Oswald Buddenhagen wrote: > On Fri, Dec 28, 2012 at 08:36:21AM -0600, Glen Mabey wrote: >> Issue 8) I did not see any output from the sanity bot when I did a >> git commit even though I had installed the symlink >> /.git/hooks/post-commit to git_post_commit_hook … any tips for getting >> that to run would be appreciated. >> > don't symlink. make it a script which contains nothing else than: > > #! /bin/sh > exec "<abspath>/git_post_commit_hook" "$@"
I'll make that change. Someone might consider modifying http://qt-project.org/wiki/Setting-up-Gerrit which is what led me to install the symlink. > if that doesn't just work, then i don't know. try running the script > manually (give it some sha1 as a parameter, iirc). Yes, passing the commit hash did work, thanks. >> Issue 9) Since the code consists of just .h files, there is no need >> to have them added to include/QtCore/QtCore . >> > huuuuuh? this it a complete non-sequitur. Okay, I now understand the difference between QtCore and QtGlobal -- somehow I thought that QtCore was included every time *any* Qt header was included, and since QNDArray does imply quite a few lines of header code, I was trying to minimize the total lines that have to be processed (I understand that boost had quite a problem with that in times past). So, yes, you're right -- there's probably no reason to prevent QNDA*.h from being included in QtCore. Thanks for your reply! Glen _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
