On 26 January 2014 20:41, Thiago Macieira <thiago.macie...@intel.com> wrote: > On domingo, 26 de janeiro de 2014 18:31:18, Tomasz Siekierda wrote: >> > The scores are now: >> > -1 - I would prefer this is not merged as is >> > -2 - This shall not be merged >> > >> > I suggest configuring qt-project gerrit to something similar. >> > >> > Opinions? >> >> A big +1 from me. I know this might sound unimportant or even silly >> for people with some Gerrit experience, but the current wording really >> does put off newbies. I can definitely remember the rejection I felt >> when I've first seen a -1 for my patch The thing is that in gerrit >> it's not so easy (especially when you see it for the first time) to >> actually notice that the text is just a standard template. One assumes >> it comes directly from the reviewer, and the lyrics used are not very >> nice > > -1 actually means "I think this needs change, but if someone else approves it, > I'm not against it"
Sure, I know that now, and with that knowledge I don't really mind the current text (or any other one: when I see -1, I simply know what it means). That is why I say it's about newcomers. Getting one's head around all the bureaucracy required to submit a patch to Qt (making sure the patch is sent correctly to Gerrit is especially scary) is pretty hard already. If one then sees the current text for -1 and -2, one can really get discouraged enough to abandon the idea of sending more patches. I know that from my own experience, and from several hints I got from some users of our forums. I do think we should get back to the actual question in the topic, though :) _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
