On Saturday 16 Aug 2014 19:29:39 Thiago Macieira wrote: > On Sunday 17 August 2014 01:48:05 Giuseppe D'Angelo wrote: > > Il 16/08/2014 20:25, Thiago Macieira ha scritto: > > > Please either: > > > > > > a) remove it > > > b) make it private > > > c) move it to QtNetwork > > > > I wouldn't worry too much about it, wip/newapi doesn't contain that > > class any more, and it's going to be merged into master soon™... > > Oh boy, I sure hope not. That branch is in a worse state than the current > master.
Well, peppe meant after a cleanup. > This is after two hours playing with that branch: > > * There are tons of classes that must have never gone through a single round > of API reivew. Do we really need all of those rendered and backend classes > as part of the public API? I'm cleaning these up now. First batch has already been merged. More to follow. > * Probably not, since there was even one public header including private > headers (fixed). I'm guessing that there are plenty of public headers that > shouldn't be public at all. (fixed) > > * headerscheck was apparently never run on this module... (issues fixed) > > * Coding style violated in a LOT of places. I've fixed it where I had to fix > other things. Yep, we will clean these up prior to release too. > * The quality of 3rdparty/assimp codebase is apparently very bad. See > attachments. So bad we will be removing assimp from 3rdparty and instead have it as an optional external dependency. > * The module does not compile with GL ES. > > qgraphicshelpergl3.cpp:63:28: error: invalid use of incomplete type ‘class > QOpenGLFunctions_3_2_Core’ > qgraphicshelpergl2.cpp:172:23: error: ‘GL_ALPHA_TEST’ was not declared in > this scope > blendstate.cpp:227:14: error: ‘GL_STENCIL’ was not declared in this scope > > I have no clue how to fix this. Paul is looking at this. > Fixes: > https://codereview.qt-project.org/92423 > https://codereview.qt-project.org/92424 > https://codereview.qt-project.org/92425 > https://codereview.qt-project.org/92426 > https://codereview.qt-project.org/92427 > https://codereview.qt-project.org/92428 > https://codereview.qt-project.org/92429 > https://codereview.qt-project.org/92430 > https://codereview.qt-project.org/92431 Thank you for those. Sean -- Dr Sean Harmer | sean.har...@kdab.com | Managing Director UK Klarälvdalens Datakonsult AB, a KDAB Group company Tel. Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322) KDAB - Qt Experts - Platform-independent software solutions _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
