Hi, Why do we need to pin anything beyond the regular git submodules handling of qt5.git (where the information is in the tree object)?
In think we should have a configuration file in each module listing required and optional dependencies. Qt.pro can interpret that file and so can the CI system. To the CI system the optional dependencies are also required ones. Simon Original Message From: Thiago Macieira Sent: Wednesday, June 10, 2015 18:44 To: development@qt-project.org Subject: Re: [Development] Specifying module dependencies On Wednesday 10 June 2015 18:30:34 Frederik Gladhorn wrote: > 4) qt5.git > in qt.pro we list all modules again, with deps: > addModule(qtdeclarative, qtbase, qtsvg qtxmlpatterns) > (amusingly this is not even correct, qtsvg is not a dependency of > qtdeclarative any more) That's an optional dependency. Note that the qt.pro file allows us to do the full build, so unless we teach qmake to parse any other sources, we'll need to keep it. That said, I don't think qt.pro should keep SHA-1 of pinned revisions, so we'll need something else anyway. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
