On 11/06/15 16:26, "Marc Mutz" <marc.m...@kdab.com> wrote: >On Thursday 11 June 2015 13:56:12 Knoll Lars wrote: >> >- QAbstractVideoFilter should re-use QObject::d_ptr instead of adding >>its >> >own >> > (though its unclear why it's inheriting QObject in the first place). >> >> It could, since the module depends on private apis in Qt Core anyway. >> Still, no show stopper for me. > >Can't be changed later, as it would be BiC. And since it only adds a >bool, >having its own d_ptr is kinda _really_, _really_ overkill. > >> And it’s a QObject, because it gets exposed >> to QML. > >That's not a reason, is it? There's other ways (Q_GADGET?) to get stuff >into >QML without carrying the baggage of a QObject around, aren't there?
The semantics for gadgets and objects in QML are different. The QObject makes sense here. I don’t see a big problem, as you’ll never instantiate thousands of these objects anyway. Lars _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
