27.10.2016, 19:44, "Rolland Dudemaine" <roll...@ghs.com>: > Using the GHS compiler, i see thousands of examples of this. > To the point that (bad practice warning!) I disabled the warning.
Better take clang-tidy and fix up things automatically > > --Rolland > ---------------------------------------- > De: Giuseppe D'Angelo <giuseppe.dang...@kdab.com> > Envoyé: 27 oct. 2016 18:36 > À: Александр Волков; development@qt-project.org > Objet: Re: [Development] Branch for adding Q_DECL_OVERRIDEs > >> Hi, >> >> please keep the discussion on the mailing list, so others can chime in. >> >> Il 27/10/2016 17:47, Александр Волков ha scritto: >>> 27.10.2016 18:19, Giuseppe D'Angelo пишет: >>>> Don't worry too much. To minimize merge conflicts I'm quite sure we'll >>>> keep using Q_DECL_OVERRIDE as long as 5.6 will be open. So use that :) >>>> We'll do a cleanup pass in the future. >>> >>> BTW, should 'override' be added in the following case: >>> struct A { >>> virtual void f(); >>> }; >>> struct B : A { >>> void f() final; // override also? >>> }; >>> ? >>> >>> Unfortunately gcc reports a warning for f() >>> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010) >>> There some such places in Qt, for example in >>> corelib/kernel/qeventdispatcher_glib_p.h, >>> where Q_DECL_OVERRIDE should be added to make it compilable with gcc >>> [-Werror, -Wsuggest-override]. >>> The question is whether to follow a reasonable style >>> https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rh-override >>> or a style forced by gcc? >> >> To be honest I don't know if we have a consensus on this. (How many >> cases of "final" in our classes do we have anyhow?) >> >> Cheers, >> -- >> Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Senior Software Engineer >> KDAB (UK) Ltd., a KDAB Group company | Tel: UK +44-1625-809908 >> KDAB - Qt, C++ and OpenGL Experts > > , > > _______________________________________________ > Development mailing list > Development@qt-project.org > http://lists.qt-project.org/mailman/listinfo/development -- Regards, Konstantin _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development