On 11 July 2017 at 22:13, Marc Mutz <marc.m...@kdab.com> wrote: > On 2017-07-08 00:39, Matteo wrote: > >> Hi all, >> >> I just finished the first preview of my QAESEncryption class and I >> would like to have some opinions on possible improvements, issues etc. >> >> https://github.com/bricke/Qt-AES [1] >> >> This is still a work in progress but I feel it's good enough to be >> shared and I am ready to take the heat! >> > > Don't implement the cipher yourself. Wrap an existing, widely-used and > audited crypto library instead. >
I'm with Marc. I'd also add that anything that uses crypto and directly references a specific cipher is designed wrong. Rich.
_______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
