+1 from me, just an addendum: On Fri, Oct 13, 2017 at 05:15:03PM +0200, Frederik Gladhorn wrote: > Hi all, <snip> > > That does not mean we should ignore anyone or be disrespectful. I expect > everyone independent of employer to be positive and friendly in reviews. > Reviews are sadly negative by nature, but please assume good intentions and > try to phrase thing positively, ask questions and make the process work for > everyone.
I just wanted to point out that "reviews are sad and negative by nature" just at first sight. In the end, 100% of my patches got merged at way better shapes than Patchset 1 - it was exactly the harsh reviews that pushed the bar higher and brought about better code. A lot of people has driven me crazy during the process, you know who you are, and I am nothing but thankful. Reviews are just like working out: you get sore muscles, it hurts, but when the result comes, it is for the best. They are actually positive! Also, you get learn when your patch is reviwed but also when you are the reviewer. Rafael -- Rafael Roquetto | rafael.roque...@kdab.com | Software Engineer Klarälvdalens Datakonsult AB, a KDAB Group company Tel. Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322) KDAB - The Qt, C++ and OpenGL Experts
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development