On 2019-11-29 08:15, Ville Voutilainen wrote:
On Wed, 27 Nov 2019 at 17:52, Sérgio Martins via Development
<development@qt-project.org> wrote:
(...)
I suggest we rename such signals, as KDE is already doing for KF6
(maybe
leave the old signatures there, to reduce Qt6 SIC)
There's also a new clazy check 'overloaded-signal' to help finding
them.
(...)
Any thoughts
on overloaded slots, or overloaded member functions as slot-targets?
The latter are a tad
harder to diagnose.
slots are a different case, since you can simply connect to a lamdba
that calls the slot. Which is already
what you do when the slot arguments don't match, too.
Another difference is that many slots are setters. Renaming setters
starts to feel weird.
So I would leave the slots alone.
List of overloaded stuff in qtbase:
slots: https://paste.ubuntu.com/p/5q2n9r3F5D/
signals: https://paste.ubuntu.com/p/cSd9hVPb9Z/
Regards,
--
Sérgio Martins | sergio.mart...@kdab.com | Senior Software Engineer
Klarälvdalens Datakonsult AB, a KDAB Group company
Tel: Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
KDAB - The Qt, C++ and OpenGL Experts
_______________________________________________
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
