A lot has happened over at https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews (thanks to Kai for significant additions early on and Eddy and Ahmad for various fixes).
It would be nice if this could be less of a one-man show, though, so, please, peruse and contribute! Thanks, Marc On 05.01.24 09:28, Marc Mutz via Development wrote: > Hi, > > In the hope of spreading knowledge, I've created a staging area in the > wiki called "Things to look out for in reviews." This is a > low-entry-barrier way to quickly publish a guideline. After each > release, we should discuss where to move these "things" to, see the page > for details: > > https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews > > Feel free to contribute, either with your own guidelines, or with > contributions to the Talk page. > > I'll keep on adding as I find stuff. > > I had a similar page back at KDAB, which ended up seeding the initial > Clazy rule set. > > Thanks, > Marc > > On 05.01.24 06:49, Jani Heikkinen via Development wrote: >> Hi! >> >> Qt 6.7 API Change Review is finally started, see >> https://bugreports.qt.io/browse/QTBUG-119952 >> <https://bugreports.qt.io/browse/QTBUG-119952> >> >> generated diffs are here: >> >> * https://codereview.qt-project.org/q/topic:api-change-review-6.7 >> <https://codereview.qt-project.org/q/topic:api-change-review-6.7> >> * https://codereview.qt-project.org/q/topic:qml_api_review_6.7 >> <https://codereview.qt-project.org/q/topic:qml_api_review_6.7> >> >> Please review the diffs as soon as possible. >> >> br, >> >> Jani >> >> -- Marc Mutz <marc.m...@qt.io> Principal Software Engineer The Qt Company Erich-Thilo-Str. 10 12489 Berlin, Germany www.qt.io Geschäftsführer: Mika Pälsi, Juha Varelius, Jouni Lintunen Sitz der Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 144331 B -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
