Hi Reza, On Sun, Jul 6, 2014 at 1:52 AM, Reza <[email protected]> wrote: > Release is ready here for review: > http://www.rezsoft.org/devicemap/
Thanks for this, here are a few comments. On MD5 (devicemap-data-1.0.tar.gz) = 86a596167277dc3e2801cf4855f402f0 1) Did you create svn tags for each of the release archives? I'd expect something like data/devicemap-data-1.0 under http://svn.apache.org/repos/asf/incubator/devicemap/tags/ - needed to verify that the released code matches what we have in svn. The code in your release archives matches revision 1608287 so if you didn't create a tag yet you can just create one from that revision. 2) In ./devicemap-data/CREDITS.txt I would remove the OpenDDR license info. That data is now released under Apache License, those mentions are confusing IMO. Ok to keep the credits of course. 3) devicemap-data doesn't need references to Modernizr and matchMedia.js in NOTICE, it does not use them. Apart from that the devicemap-data archive looks good to me. On MD5 (devicemap-java-1.0.tar.gz) = 33efb7aa9b86fe16c0e1264ab8ae4b4b 4) I'd remove the CREDITS.txt file from devicemap-java as that doesn't contain anything that was donated by OpenDDR 5) Same as 3) about NOTICE 6) I suggest removing the @author tags from the code, we can discuss it separately, in general we don't have them in Apache code. Not urgent, can be done after the release So those are all minor things related to the "release metadata" files, once this is fixed IMO we're go for voting on those releases here and having the Incubator PMC vote on them. -Bertrand
