-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi,
All requested corrections have been made excpet for the SVN tags thing [see below] esjr On 18/07/2014 13:11, Bertrand Delacretaz wrote: > Hi, > > On Thu, Jul 17, 2014 at 11:46 AM, eberhard speer jr. > <[email protected]> wrote: >> ...following Bertrand's guidance, I've updated the .Net Review >> release page : http://www.ducis.net/static/docs/dotnet/rel.html >> ... > > I had a look at the following archives: > SHA1(./csharp/devicemap.zip)= > ddec155204384d3e658ed6a553a79509312afddd > SHA1(./vbnet/devicemap.zip)= > 191956b5e20650ce31c7ed42be19f888925ea2b7 > > Using different names for the C# and VB.Net devicemap.zip archives > would be less confusing. Also, both need to include -incubating in > their name. I suggest devicemap-csharp-incubating-1.0.0.zip (or > whatever the version number is) and the same with -vbnet. No problem, devicemap-csharp-incubating-1.0.0.zip devicemap-vbnet-incubating-1.0.0.zip it is > I don't see svn tags under > http://svn.apache.org/repos/asf/incubator/devicemap/tags/releases/ > , could you create or move them there, one tag per release > archive? What's under the tags should match what's in the release > archives. Not a clue about this tag business, looks to me like an exact copy of what's under trunk, so, if someone could move it to where you like it...done. > > Both archives contain a number of binary files, including .exe > .dll and even a .git folder - that's not ok, Apache releases source > code only. Can you reduce them to the actual source code and > remove anything that's not required for someone to build the > software themselves? > > I see that there's also a good number of binary files in svn under > devicemap/csharp and devicemap/vbnet. I'm clueless about C# and > VB.Net but I hope this is not needed - we should also have only > source code in our svn repository. Is that something that you can > easily fix, or do those environment require binaries to be checked > in in order to build the projects? they can be removed, no problem, left-overs from tests > HTH, -Bertrand > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTyQA8AAoJEOxywXcFLKYco1MH/2pbGejuUaJSVeku+uY7KLKu 1sv6HP3eoDFK7PR6NIV/iuFAQUhZsLrYfzeR7B4xpHA6IuSL1lMi/JZNZtZxwUGh XqW0L0ldyeGR+8enF6veM2W0Y7PXBUpqWabhv1r/e7qM45SPbOXH5KfTwi/IFLCq TdiXBaDoA74+Hgkf3sFcGDpkjpPdQWX0IUNeAYJnzbPdw8Ov8XxPi59Ijd91DehH AWAEXtCCQYFIofriRndWub9olFuG/295hcG5xbPNqKln6vQy6z7w4FotGWRaG+y0 c97ZtluUyvVf29XDi/1FrRy2KYyzOPQp+/51LbnMugme+5MXV06ufTnSOuyz2jw= =2+59 -----END PGP SIGNATURE-----
