On Tue, Sep 29, 2015 at 03:54:46PM +1000, David Gibson wrote:
> On Thu, Jul 16, 2015 at 01:10:20PM +0200, Thierry Reding wrote:
> > From: Thierry Reding <tred...@nvidia.com>
> > 
> > Given a device tree node and a property name, the new fdt_find_string()
> > function will look up a given string in the string list contained in the
> > property's value and return its index.
> > 
> > Signed-off-by: Thierry Reding <tred...@nvidia.com>
> 
> This also looks good, except for the name.  I'd prefer
> 'fdt_stringlist_search()' again to match the existing
> 'fdt_stringlist_contains()'.

Done.

> Speaking of which, fdt_stringlist_contains() could be reimplemented in
> terms of this function.

Unfortunately it can't. fdt_stringlist_contains() doesn't operate on the
device tree node and property but rather on the raw stringlist itself.

Thierry

Attachment: signature.asc
Description: PGP signature

Reply via email to