On Fri, Jul 08, 2011 at 06:20:18PM +0800, Haojian Zhuang wrote: > Remove builtin gpio driver support form mmp. > > Signed-off-by: Haojian Zhuang <haojian.zhu...@marvell.com>
Hi Haojian. I'm not clear what this patch is intending to do. I understand that it removes the mmp-specific gpio support, but I looks like don't see the code that replaces it, which would mean that applying this patch breaks gpio on mmp platforms. Am I missing something? > diff --git a/arch/arm/plat-pxa/Makefile b/arch/arm/plat-pxa/Makefile > index 3aca5ba..8e432b1 100644 > --- a/arch/arm/plat-pxa/Makefile > +++ b/arch/arm/plat-pxa/Makefile > @@ -4,7 +4,9 @@ > > obj-y := dma.o > > +ifeq ($(CONFIG_OF),) > obj-$(CONFIG_GENERIC_GPIO) += gpio.o > +endif Be careful about this. Turning on device tree support must not disable booting on non-DT machines. g. _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss
