On Thu, Sep 22, 2011 at 5:13 PM, David Gibson <da...@gibson.dropbear.id.au> wrote: > On Thu, Sep 22, 2011 at 10:57:58AM -0700, Anton Staaf wrote: >> On Wed, Sep 21, 2011 at 7:33 PM, David Gibson >> <da...@gibson.dropbear.id.au> wrote: >> > On Wed, Sep 21, 2011 at 01:42:10PM -0700, Anton Staaf wrote: > [snip] >> >> + >> >> + if ((len < 64) && (value >= (1ULL << len))) >> >> + die("Literal value 0x%x too large to fit in %d-bit cell\n", >> >> + value, len); >> > >> > This really shouldn't be a die(). In general bad input should not >> > directly trigger a die() during parse - it should give an error but >> > continue parse as best it can and only drop out afterwards. >> >> Hmm, so this check should never happen when called from the >> parser because the parser uses eval_literal to read the cell values >> and that function also checks this. > > Um.. it checks and prints an error, but it doesn't die() or otherwise > stop you from reaching here AFAICT.
Hah, yes, you are correct. The same is true for the other die as well then I think. I'll take a closer look tomorrow. Thanks, Anton > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson > _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss