Hello Sergei, Sergei Shtylyov wrote: > Hello. > > On 04-12-2011 13:41, Heiko Schocher wrote: > >> Signed-off-by: Heiko Schocher<h...@denx.de> >> Cc: davinci-linux-open-sou...@linux.davincidsp.com >> Cc: devicetree-discuss@lists.ozlabs.org >> Cc: linux-arm-ker...@lists.infradead.org >> Cc: grant.lik...@secretlab.ca >> Cc: Sekhar Nori<nsek...@ti.com> >> Cc: Kevin Hilman<khil...@ti.com> >> Cc: Wolfgang Denk<w...@denx.de> > >> diff --git a/arch/arm/mach-davinci/aemif.c >> b/arch/arm/mach-davinci/aemif.c >> index 1ce70a9..12c559f 100644 >> --- a/arch/arm/mach-davinci/aemif.c >> +++ b/arch/arm/mach-davinci/aemif.c > [...] >> @@ -131,3 +138,99 @@ int davinci_aemif_setup_timing(struct >> davinci_aemif_timing *t, >> return 0; >> } >> EXPORT_SYMBOL(davinci_aemif_setup_timing); >> + >> +#if defined(CONFIG_OF) >> +static int dv_get_value(struct device_node *np, const char *name) >> +{ >> + const u32 *data; >> + int len; >> + >> + data = of_get_property(np, name,&len); >> + if (data) >> + return be32_to_cpu(readl(data)); > > Why readl() here?! Device tree is not a peripheral device... > >> + >> + return -EINVAL; >> +} > > Isn't there already a standard helper for that, of_property_read_u32()?
Yep, fixed that. Thanks! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss