On Mon, Apr 23, 2012 at 7:01 PM, John Crispin <blo...@openwrt.org> wrote:
> pinmux_map_to_setting() uses setting->data.mux.func/group to store the return > code of pinmux_func_name_to_selector/pinctrl_get_group_selector(). However, > struct pinctrl_setting_mux defines these elements as unsigned, resulting in > all > error codes getting lost. The conditionals following the assignments will > always > evaluate to false thus breaking the error paths. > > This bug can be triggered by loading a pinmux group map from the devicetree > with an invalid function/group string. > > Signed-off-by: John Crispin <blo...@openwrt.org> > Cc: Stephen Warren <swar...@nvidia.com> > Cc: Dong Aisheng <dong.aish...@linaro.org> Applied with Stephen and Dong's ACKs, thanks! New contributors to pinctrl, I love this :-) Yours, Linus Walleij _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss
