On Tue, 2012-05-08 at 08:48 -0700, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, May 08, 2012 at 11:42:42AM -0700, Rhyland Klein wrote:
>
> > + if (pdata->irq_base <= 0)
> > + pdata->irq_base = irq_alloc_descs(-1, 0, tps65910->irq_num, -1);
> > +
> > + if (pdata->irq_base <= 0) {
> > + dev_err(tps65910->dev, "Failed to allocate irq descs: %d\n",
> > + pdata->irq_base);
> > + return pdata->irq_base;
> > + }
>
> I'd expect the driver to always call irq_alloc_descs() but to use the
> value specified in platform data if there is any. This is the normal
> way of doing things, anyway.
>
Is this more what you would expect? If the dt code initialized the
irq_base to 0 instead of -1 then this should also work.
pdata->irq_base = irq_alloc_descs(-1, pdata->irq_base,
tps65910->irq_num, -1);
if (pdata->irq_base <= 0) {
dev_err(tps65910->dev, "Failed to allocate irq descs: %d\n",
pdata->irq_base);
return pdata->irq_base;
}
> * Unknown Key
> * 0x6E30FDDD
--
nvpublic
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
