On Friday 20 July 2012, Tony Prisk wrote:
> Signed-off-by: Tony Prisk <li...@prisktech.co.nz>
> ---
>  .../devicetree/bindings/usb/vt8500-ehci.txt        |   10 ++++++++++
>  drivers/usb/host/ehci-vt8500.c                     |    9 +++++++++
>  2 files changed, 19 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/usb/vt8500-ehci.txt

As mentioned, you need to Cc the USB mailing list and the EHCI maintainers:

$ ./scripts/get_maintainer.pl drivers/usb/host/ehci-vt8500.c -f
Alan Stern <st...@rowland.harvard.edu> (maintainer:USB EHCI DRIVER)
Greg Kroah-Hartman <gre...@linuxfoundation.org> (supporter:USB SUBSYSTEM)
linux-...@vger.kernel.org (open list:USB EHCI DRIVER)
linux-ker...@vger.kernel.org (open list)


> diff --git a/Documentation/devicetree/bindings/usb/vt8500-ehci.txt 
> b/Documentation/devicetree/bindings/usb/vt8500-ehci.txt
> new file mode 100644
> index 0000000..74f75c6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/vt8500-ehci.txt
> @@ -0,0 +1,10 @@
> +VIA VT8500 and Wondermedia WM8xxx SoC USB controllers.
> +
> +Required properties:
> + - compatible: Should be "via,vt8500-ehci" or "wm,prizm-ehci".

I would list the interrupts and reg properties as required as well,
and you can mention that there must be exactly one interrupt and one
reg resource with a length of 0x200 bytes.

        Arnd
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Reply via email to