Hi Thierry,
On Mon, Jul 23, 2012 at 02:18:47PM +0200, Thierry Reding wrote:
> +
> + if (gpio_is_valid(sx->power_gpio)) {
> + err = gpio_request(sx->power_gpio, "sx8634 power");
> + if (err < 0) {
> + dev_err(&client->dev,
> + "failed to request power GPIO#%u: %d\n",
> + sx->power_gpio, err);
> + goto free_input_device;
> + }
> +
> + err = gpio_direction_output(sx->power_gpio, 1);
> + if (err < 0) {
> + dev_err(&client->dev, "failed to enable power: %d\n",
> + err);
> + goto free_power_gpio;
> + }
I think there is gpio_request_one() that will take care of tehse 2
calls.
> +
> + msleep(150);
> + }
> +
> + err = sx8634_setup(sx, pdata);
> + if (err < 0)
> + goto free_power_gpio;
> +
> + err = sysfs_create_group(&client->dev.kobj, &sx8634_attr_group);
> + if (err < 0)
> + goto free_power_gpio;
> +
> + err = devm_request_threaded_irq(&client->dev, client->irq, NULL,
> + sx8634_irq, IRQF_ONESHOT, "sx8634",
> + sx);
Please do not use devm_* interface here as it make the driverr bomb in
remove() where you unregister input device but keep interrupt handler
active until after remove() finishes.
> +
> +#ifdef CONFIG_PM_SLEEP
> +static int sx8634_i2c_suspend(struct device *dev)
> +{
> + return 0;
> +}
> +
> +static int sx8634_i2c_resume(struct device *dev)
> +{
> + return 0;
> +}
> +#endif
> +
> +static SIMPLE_DEV_PM_OPS(sx8634_i2c_pm, sx8634_i2c_suspend,
> sx8634_i2c_resume);
Why are these stubs needed?
Thanks.
--
Dmitry
_______________________________________________
devicetree-discuss mailing list
[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss
