On 28/07/12 01:23, Linus Walleij wrote: > On Tue, Jul 24, 2012 at 8:50 AM, John Crispin <blo...@openwrt.org> wrote: > >> Implement support for pinctrl on lantiq/falcon socs. The FALCON has 5 banks >> of up to 32 pins. >> >> Signed-off-by: John Crispin <blo...@openwrt.org> >> Signed-off-by: Thomas Langer <thomas.lan...@lantiq.com> >> Cc: Linus Walleij <linus.wall...@linaro.org> >> Cc: devicetree-discuss@lists.ozlabs.org >> Cc: linux-ker...@vger.kernel.org > No big issues and looking really sweet so: > Acked-by: Linus Walleij <linus.wall...@linaro.org> > >> --- a/arch/mips/lantiq/Kconfig >> +++ b/arch/mips/lantiq/Kconfig >> @@ -20,6 +20,7 @@ config SOC_XWAY >> >> config SOC_FALCON >> bool "FALCON" >> + select PINCTRL_FALCON > I think you need to add "select PINCTRL" above "select PINCTRL_FALCON" > for this to work. > > Atleast I had to do that in the past to get things working.
Hi Linus, config LANTIQ selects PINCTRL globally for all Lantiq SoC so an explicit select can be avoided here Thanks for the review, John _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss
