On Tue, Oct 2, 2012 at 9:59 PM, Andrew Lunn <and...@lunn.ch> wrote: >> I was thinking to add a more generic helper function like this: >> >> static inline void watchdog_get_dttimeout(struct device_node *node, >> u32 *timeout) >> { >> if (node) >> of_property_read_u32(node, "timeout", &wdd->timeout); >> } > > You forgot to change the function signature. > > Also, if you are adding a generic function, it should be a generic > function for the framework. All drivers should be slowly moving > towards the framework, so adding functions which help you not move > towards the framework are wrong.
Maybe i can use a framework specific function and use a dummy watchdog_device for the non framerwork drivers. If it's ok i will send an updated patch. Best regards and thanks for the review. -- Fabio Porcedda _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss