> I prefer u32 here, because we have the matching enum. Otherwise we end > up with: > > of_property_read_string(...,&type); > > if (!strcmp(type, "ulpi")) > foo(); > else if (!strcmp(type, "utmi")) > bar(); > else if (!strcmp(type, "pipe3")) > baz(); > else > BUG(); > > and I don't like that, it's ugly and error prone.
Error prone? I guess my mileage varies. Especially compared to the probability devicetree creators pick the wrong number. It also removes the (probably implicit) rule that the enum mustn't be modified since it is exported to users. Also, you could map the strings to the enum first and then switch-case over it to make the code nicer. -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
_______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss
