On 02/20/2013 05:17 AM, Lars-Peter Clausen wrote: > On 02/20/2013 01:48 AM, Kuninori Morimoto wrote: >> >> Hi Lars >> >> Thank you for checking patch >> >>>> +- simple-audio,dev : phandle and port for CPU/CODEC >>>> +- simple-audio,frame-master : frame master >>>> +- simple-audio,bitclock-master : bitclock master >>>> +#sound-dai-cells integer is required on simple-audio,dev phandle's node >>> >>> Shouldn't the names of '#sound-dai-cells' and 'simple-audio,dev' kind of >>> match? E.g. '#sound-dai-cells' and 'sound-dai'. Maybe drop the sound, since >>> the a in dai kind of implies this. >> >> Thank you, but I would like to keep "simple-audio" name for it too. >> So, can I use >> simple-audio-dai >> #simple-audio-dai-cells > > The requirement to be able to find the DAI via devicetree is not specific to > the simple-audio driver. I'd prefer if we could come up with a common > binding which can be used by multiple drivers. Since you also add the xlate > (or match) function to the sound core it makes sense - in my option - to > also have a generic phandle -> DAI look-up method in the core.
I agree here; the whole reason I've been pushing on creating a standardized of_xlate_dai_name function and a standardized #sound-dai-cells property is to allow the exact same property name and function to be used for any audio-related DT binding. _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss