On 3/5/2013 4:54 PM, Manjunathappa, Prakash wrote: >>> + pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); >>> + if (!pdata) { >>> + dev_err(&pdev->dev, "Failed to allocate memory for struct >>> davinci_mmc_config\n"); >>> + goto nodata; >> >> devm_kzalloc() returns NULL on error so you will end up returning >> success in this case. >> > > Returns NULL on failure, caller is checking on NULL for failures. > > pdata = mmc_parse_pdata(pdev); > if (pdata == NULL) { > dev_err(&pdev->dev, "Can not get platform data\n"); > return -ENOENT; > }
Ha, okay. I was somehow confused into thinking this is part of probe routine. Thanks, Sekhar _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss