On Fri, Mar 15, 2013 at 11:42:48AM +0800, Shawn Guo wrote: > On Thu, Mar 14, 2013 at 02:08:32PM +0100, Markus Pargmann wrote: > > On Wed, Mar 13, 2013 at 10:18:29AM +0800, Shawn Guo wrote: > > > On Tue, Mar 12, 2013 at 07:02:07PM +0000, Mark Brown wrote: > > > > On Sun, Mar 10, 2013 at 07:33:09PM +0100, Markus Pargmann wrote: > > > > > Add a function to open a DMA PCM substream using devicetree data > > > > > provided via the client device node. The patch introduces a public > > > > > function and a private subfunction that is called by both open > > > > > functions. > > > > > > > > Someone (I think it was Shawn) sent a very similar patch just recently > > > > which appears to have fallen out of my inbox unfortunately - can you > > > > please check what's going on there and coordinate with them? Let me > > > > know if you can't find the patch and I'll dig it out. > > > > > > It's here, Markus. > > > > > > http://thread.gmane.org/gmane.linux.alsa.devel/106027/focus=106031 > > > > > > > Thanks. Do you already have a patch for the non-generic function which I > > could use instead? > > > I do not follow. With my patch in place, there will be two > dmaengine_pcm APIs. > > int snd_dmaengine_pcm_open(struct snd_pcm_substream *substream, > dma_filter_fn filter_fn, void *filter_data) > > int snd_dmaengine_generic_pcm_open(struct snd_pcm_substream *substream, > struct device *dev, const char *name) > > The first one is for users that their dmaengine driver hasn't converted > to generic device tree bindings, and the second one is for users that > their dmaengine driver is converted to generic device tree bindings.
Sorry, I mixed up different patch versions and was confused. Regards, Markus -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss