Hi Prabhakar,

Thank you for the patch.

On Friday 03 May 2013 12:21:59 Prabhakar Lad wrote:
> From: Lad, Prabhakar <prabhakar.cse...@gmail.com>
> 
> add OF support for the mt9p031 sensor driver.
> Alongside this patch sorts the header inclusion alphabetically.
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.cse...@gmail.com>
> Cc: Hans Verkuil <hans.verk...@cisco.com>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Cc: Mauro Carvalho Chehab <mche...@redhat.com>
> Cc: Guennadi Liakhovetski <g.liakhovet...@gmx.de>
> Cc: Sylwester Nawrocki <s.nawro...@samsung.com>
> Cc: Sakari Ailus <sakari.ai...@iki.fi>
> Cc: Grant Likely <grant.lik...@secretlab.ca>
> Cc: Sascha Hauer <s.ha...@pengutronix.de>
> Cc: Rob Herring <rob.herr...@calxeda.com>
> Cc: Rob Landley <r...@landley.net>
> Cc: Arnd Bergmann <a...@arndb.de>
> Cc: devicetree-discuss@lists.ozlabs.org
> Cc: davinci-linux-open-sou...@linux.davincidsp.com
> Cc: linux-...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org
> ---
>  Changes for v2:
>  1: Used '-' instead of '_' for device properties.
>  2: Specified gpio reset pin as phandle in device node.
>  3: Handle platform data properly even if kernel is compiled with
>     devicetree support.
>  4: Used dev_* for messages in drivers instead of pr_*.
>  5: Changed compatible property to "aptina,mt9p031" and "aptina,mt9p031m".
>  6: Sorted the header inclusion alphabetically and fixed some minor code
> nits.
> 
> Changes for v3:
>  1: Dropped check if gpio-reset is valid.
>  2: Fixed some code nits.
>  3: Included a reference to the V4L2 DT bindings documentation.
> 
>  .../devicetree/bindings/media/i2c/mt9p031.txt      |   40 +++++++++++++
>  drivers/media/i2c/mt9p031.c                        |   60 ++++++++++++++++-
>  2 files changed, 97 insertions(+), 3 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> b/Documentation/devicetree/bindings/media/i2c/mt9p031.txt new file mode
> 100644
> index 0000000..e740541
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/mt9p031.txt
> @@ -0,0 +1,40 @@
> +* Aptina 1/2.5-Inch 5Mp CMOS Digital Image Sensor
> +
> +The Aptina MT9P031 is a 1/2.5-inch CMOS active pixel digital image sensor
> with +an active array size of 2592H x 1944V. It is programmable through a
> simple +two-wire serial interface.
> +
> +Required Properties :
> +- compatible : value should be either one among the following
> +     (a) "aptina,mt9p031" for mt9p031 sensor
> +     (b) "aptina,mt9p031m" for mt9p031m sensor
> +
> +- input-clock-frequency : Input clock frequency.
> +
> +- pixel-clock-frequency : Pixel clock frequency.
> +
> +Optional Properties :
> +-gpio-reset: Chip reset GPIO

According to Documentation/devicetree/bindings/gpio/gpio.txt, this should be 
"gpios" or "reset-gpios".

> +
> +For further reading of port node refer
> Documentation/devicetree/bindings/media/ +video-interfaces.txt.
> +
> +Example:
> +
> +     i2c0@1c22000 {
> +             ...
> +             ...
> +             mt9p031@5d {
> +                     compatible = "aptina,mt9p031";
> +                     reg = <0x5d>;
> +                     gpio-reset = <&gpio3 30 0>;
> +
> +                     port {
> +                             mt9p031_1: endpoint {
> +                                     input-clock-frequency = <6000000>;
> +                                     pixel-clock-frequency = <96000000>;
> +                             };
> +                     };
> +             };
> +             ...
> +     };

-- 
Regards,

Laurent Pinchart

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

Reply via email to