On Fri, May 24, 2013 at 05:59:19PM +0800, Huang Shijie wrote: > +Example for an imx6q-sabreauto board, the NOR flash connected to the WEIM: > + > + weim: weim@021b8000 { > + compatible = "fsl,imx6q-weim"; > + reg = <0x021b8000 0x4000>; > + clocks = <&clks 196>; > + #address-cells = <2>; > + #size-cells = <1>; > + ranges = <0 0 0x08000000 0x08000000>; > + > + nor@0,0 { > + compatible = "cfi-flash"; > + reg = <0 0 0x02000000>; > + #address-cells = <1>; > + #size-cells = <1>; > + bank-width = <2>; > + Nit: remove this unneeded blank line. > + fsl,weim-cs-timing = <0x00620081 0x00000001 0x1C022000 > + 0x0000C000 0x1404a38e 0x00000000>;
Nit: please consistently use lower case for hex value. Please update patch #6 as well. Other than that, Reviewed-by: Shawn Guo <shawn....@linaro.org> > + }; > + }; _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss