On Thursday 30 May 2013, Pavel Machek wrote: > On Wed 2013-05-29 17:19:20, Stephen Warren wrote: > > On 05/28/2013 09:06 AM, Philipp Zabel wrote: > > > This driver implements a reset controller device that toggle a gpio > > > connected to a reset pin of a peripheral IC. The delay between assertion > > > and de-assertion of the reset signal can be configured via device tree. > > > > > diff --git a/drivers/reset/gpio-reset.c b/drivers/reset/gpio-reset.c > > > > > +static void __gpio_reset_set(struct reset_controller_dev *rcdev, int > > > asserted) > > > > Nit: Technically I think __ is a reserved name-space, so you shouldn't > > prefix "user-level" (rather than libc/similar) symbols with it, but it's > > not a big deal. > > Well.. this is kernel :-). We don't have libc around... and this > standard is normally ignored here. __ is normally used as a prefix for > "simpler" function.
We're not really consistent in the kernel, but I agree the most common use is where you have a wrapper calling the __foo function and normal drivers are supposed to call foo instead. My reading is usually that by calling __foo, the caller says "I know exactly what I'm doing so I can optimize this". Arnd _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss