On Thursday 30 May 2013, ludovic.desroc...@atmel.com wrote:
> +/*
> + * Source and/or destination peripheral ID
> + */
> +#define AT91_DMA_CFG_PER_ID_MASK (0xff)
> +#define AT91_DMA_CFG_PER_ID(id) (id &
> AT91_DMA_CFG_PER_ID_MASK)
> +
I'm a little worried about macros like this one spreading in the name
of readability, and I don't see this as actual value-add here:
The output of the macro is always the same as the input, and passing
an invalid number still results in an invalid output and no error message,
it actually prevents us from warning about the mistake at run-time.
The other macros are fine.
Arnd
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
